[CASSANDRA-19890] type system contains check for duration does not work for hidden types

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.1
• Component/s: CQL/Interpreter
• Bug Category: Correctness - Unrecoverable Corruption / Loss
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: Fuzz Test
• Platform: All
• Since Version: 3.10

Source Control Link

https://github.com/apache/cassandra/commit/e8891be04a681fbd87e2bec2c07ed22e55725a04

Test and Documentation Plan

Added tests in AbstractTypeTest.java to check nested types with durations in them. 

• Assignee: Raymond Welgosh
• Reporter: David Capwell

Authors

Raymond Welgosh

Reviewers

David Capwell, Yifan Cai

• Created: 03/Sep/24 19:28
• Updated: 29/Oct/24 16:42
• Resolved: 23/Oct/24 17:56

Description

The function "org.apache.cassandra.db.marshal.AbstractType#referencesDuration” relies on type overriding for detecting if the type contains a duration, but the hidden types like Composite or DynamicComposite don’t override this… this means that we will be able to create a 2i index for these columns (unless we use SAI as it properly detects this)

CREATE TABLE "tbl" (
    "pk1" int,
    "with_duration" 'CompositeType(ListType(DurationType))',
    PRIMARY KEY ("pk1")
);
CREATE INDEX ON "tbl"("with_duration");

This is able to create the 2i index even though we shouldn’t be able to due to duration not being allowed in indexes.

We have a test method that is able to detect if a type exists in complex types:

AbstractTypeGenerators.contains(type, DurationType.instance);

Could leverage the same logic to avoid maintenance burden with inheritance

Issue Links

• relates to: CASSANDRA-20036 When snapshotting the recreate CQL does not count UDTs from reverse clustering columns
• links to: GitHub Pull Request #3621