[CASSANDRA-19866] Fix Journal segment allocation/switch race condition

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.1
• Component/s: Accord
• Bug Category: Availability - Response Crash
• Severity: Normal
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 5.1

Source Control Link

https://github.com/apache/cassandra/commit/fb7e29dd4298a5ecf93a3c2404ce0f4409e56627

Test and Documentation Plan

Covered by existing tests

• Assignee: Alex Petrov
• Reporter: Alex Petrov

Authors

Alex Petrov

Reviewers

Aleksey Yeschenko, Alex Petrov

• Created: 26/Aug/24 20:49
• Updated: 09/Sep/24 14:08
• Resolved: 09/Sep/24 14:08

Description

Concurrent r/w workload is currently throwing:

java.lang.IllegalArgumentException: Can not reference segment 1724695101990
        at org.apache.cassandra.journal.Segments.isFlushed(Segments.java:189)
        at org.apache.cassandra.journal.Journal.isFlushed(Journal.java:199)
        at org.apache.cassandra.journal.Journal$FlusherCallbacks.submit(Journal.java:151)
        at org.apache.cassandra.journal.Journal.onFlush(Journal.java:204)
        at org.apache.cassandra.service.accord.AccordJournal.appendCommand(AccordJournal.java:264)
        at org.apache.cassandra.service.accord.AccordCommandStore.appendCommands(AccordCommandStore.java:579)
        at org.apache.cassandra.service.accord.async.AsyncOperation.runInternal(AsyncOperation.java:277)
        at org.apache.cassandra.service.accord.async.AsyncOperation.run(AsyncOperation.java:303)
        at org.apache.cassandra.service.accord.async.AsyncOperation.onLoaded(AsyncOperation.java:169)
        at accord.utils.async.AsyncCallbacks.lambda$inExecutorService$0(AsyncCallbacks.java:36)
        at org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)

Issue Links

• links to: PR