[CASSANDRA-19782] Host replacements no longer fully populate system.peers table

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.x
• Component/s: Transactional Cluster Metadata
• Bug Category: Correctness - Unrecoverable Corruption / Loss
• Severity: Critical
• Complexity: Normal
• Discovered By: Fuzz Test
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/32755cabfa2eeb99f0b8c91fc7bb53379259de54

Test and Documentation Plan

Updated existing test

• Assignee: Sam Tunnicliffe
• Reporter: David Capwell

Authors

Sam Tunnicliffe

Reviewers

David Capwell

• Created: 18/Jul/24 16:47
• Updated: 04/Sep/24 16:27
• Resolved: 31/Jul/24 13:25

Description

When running harry after a host replacement was done a failure happened due to peers having the new node, but not the tokens for it (leading to a NPE in harry). I took the test org.apache.cassandra.distributed.test.hostreplacement.HostReplacementTest#replaceDownedHost and made one small change; log peers after the host replacement

4.1:

INFO  [main] <main> 2024-07-18 09:36:48,211 HostReplacementTest.java:107 - Peers table from node1:
[/127.0.0.3, datacenter0, 00000000-0000-4000-8000-000000000003, null, rack0, 4.1.5-SNAPSHOT, /127.0.0.3, 94a14fb6-2cd9-3d1d-af84-a30e257aa7b8, [9223372036854775805]]

Trunk:

INFO  [main] <main> 2024-07-18 09:38:59,568 HostReplacementTest.java:109 - Peers table from node1:
[/127.0.0.3, null, null, null, null, 5.1.0-SNAPSHOT, /127.0.0.3, 00000000-0000-0000-0000-00000000000a, null]

Several fields are missing

Issue Links

• is related to: CASSANDRA-19847 Create a fuzz test that randomizes topology changes, cluster actions, and CQL operations
• links to: Trunk PR