[CASSANDRA-19763] Reentrant locks should always be locked outside of a try block

• Type: Improvement
• Status: Triage Needed
• Priority: Low
• Resolution: Unresolved
• Fix Version/s: 5.x
• Platform: All
• Assignee: Ling Mao
• Reporter: Ling Mao

Authors

Ling Mao

• Created: 11/Jul/24 14:08
• Updated: 17/Jul/24 19:15

Description

Acquiring the lock should always be done before the try block so that the finally clause to unlock will never execute unless the lock is acquired. More info:
 

https://stackoverflow.com/questions/31058681/java-locking-structure-best-pattern
https://issues.apache.org/jira/browse/AMQ-9202

 

Unfortunately, there are no ready-made rules in Checkstyle, FindBugs, or SpotBugs for this type of violation checking. I use "IDEA inspection" to identify all such violations.

IDEA Code -> Analyze Code -> Run Inspection by Name(Lock acquired but not safely unlocked) ---> Whole project

Issue Links

• links to: GitHub Pull Request #3415