[CASSANDRA-19749] ALTER USER | ROLE IF EXISTS creates a user / role if it does not exist

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1.6, 5.0-rc1, 5.1-alpha1
• Component/s: Legacy/CQL
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.1-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/a878adfc895b2e70b058f90ad5d207c710788c4d

Test and Documentation Plan

CI

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Brandon Williams

• Created: 04/Jul/24 11:58
• Updated: 10/Jul/24 10:17
• Resolved: 09/Jul/24 15:37

Description

Let's have:

authenticator:
  class_name : org.apache.cassandra.auth.PasswordAuthenticator
authorizer: CassandraAuthorizer
role_manager: CassandraRoleManager

and do this:

cassandra@cqlsh> select * from system_auth.roles;

 role      | can_login | is_superuser | member_of | salted_hash
-----------+-----------+--------------+-----------+--------------------------------------------------------------
 cassandra |      True |         True |      null | $2a$10$sFCKeluid5MlW/Z0CU1ygO1U5qpLW4Rgivmu8rZNmNNQ8WeC2y92S

Then

cassandra@cqlsh> ALTER USER IF EXISTS this_does_not_exist SUPERUSER ;
cassandra@cqlsh> select * from system_auth.roles where role = 'this_does_not_exist';

 role                | can_login | is_superuser | member_of | salted_hash
---------------------+-----------+--------------+-----------+-------------
 this_does_not_exist |      null |         True |      null |        null

It seems to be same behaviour for ALTER ROLE too.

cassandra@cqlsh> ALTER ROLE IF EXISTS this_role_is_not_there WITH SUPERUSER = true ;
cassandra@cqlsh> select * from system_auth.roles where role = 'this_role_is_not_there';

 role                   | can_login | is_superuser | member_of | salted_hash
------------------------+-----------+--------------+-----------+-------------
 this_role_is_not_there |      null |         True |      null |        null

Issue Links

• is caused by: CASSANDRA-16916 Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
• links to: GitHub Pull Request #3407
• links to: GitHub Pull Request #3410