[CASSANDRA-19624] ModificationStatement#casInternal leaks RowIterator

• Type: Bug
• Status: Patch Available
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 4.0.x, 4.1.x, 5.0.x, 5.x
• Component/s: Legacy/Core
• Bug Category: Degradation - Resource Management
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All

Test and Documentation Plan

regression tests

• Assignee: Michael Marshall
• Reporter: Michael Marshall

Authors

Michael Marshall

Reviewers

Jacek Lewandowski

• Created: 08/May/24 14:20
• Updated: 23/May/24 07:13

Description

In the `ModificationStatement` class, the `casInternal` method opens a row iterator without closing it, causing the iterator to leak resources. Here is a link to the relevant code in the `trunk` branch.

https://github.com/apache/cassandra/blob/a77a2d10b1d247ed920b75df79f982a3b7c6a431/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L680-L684

 

It seems that `cassandra-3.0.30` has the bug, but `cassandra-2.2.19` does not have it. Is it correct to target `cassandra-3.0.30`?

What is the best practice for testing this kind of bug fix? It seems like a low complexity fix. This is my first contribution to the Cassandra community, so any guidance is appreciated. Thanks!

Issue Links

• links to: GitHub Pull Request #3296
• links to: GitHub Pull Request #3323
• links to: GitHub Pull Request #3324
• links to: GitHub Pull Request #3325
• links to: GitHub Pull Request #3326
• links to: GitHub Pull Request #3327
• links to: GitHub Pull Request #3328