[CASSANDRA-19577] Queries are not visible to the "system_views.queries" virtual table at the coordinator level

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1.5, 5.0, 5.1
• Component/s: Feature/Virtual Tables
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Low
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.1.3

Source Control Link

https://github.com/apache/cassandra/commit/428fa1f4453735ef43d508621e5e7d9e0a054415

Test and Documentation Plan

expansion of QueriesTableTest to cover coordinator-level queries in flight

• Assignee: Caleb Rackliffe
• Reporter: Caleb Rackliffe

Authors

Caleb Rackliffe

Reviewers

Chris Lohfink, David Capwell

• Created: 19/Apr/24 20:07
• Updated: 01/May/24 19:52
• Resolved: 01/May/24 19:50

Description

There appears to be a hole in the implementation of CASSANDRA-15241 where DebuggableTasks at the coordinator are not preserved through the creation of FutureTasks in TaskFactory. This means that QueriesTable can't see them when is asks SharedExecutorPool for running tasks. It should be possible to fix this in TaskFactory by making sure to propagate any RunnableDebuggableTask we encounter. We already do this in toExecute(), but it also needs to happen in the relevant toSubmit() method(s).

Issue Links

• blocks: CASSANDRA-18732 Baseline Diagnostic vtables for Accord
• links to: GitHub Pull Request #3268
• links to: GitHub Pull Request #3281
• links to: GitHub Pull Request #3281
• links to: GitHub Pull Request #3282