[CASSANDRA-19551] CCM nodes share the same environment variable map breaking upgrade tests

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.31, 3.11.17, 4.0.13, 5.0-rc1, 5.1
• Component/s: Test/dtest/python
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: DTest
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/riptano/ccm/commit/ce69e9df94f9e44f3f5b36f8ed4e2d07f734195f

Test and Documentation Plan

Run all python dtests

• Assignee: Ariel Weisberg
• Reporter: Ariel Weisberg

Authors

Ariel Weisberg

Reviewers

Berenguer Blasi, Josh McKenzie, Joshua McKenzie

• Created: 10/Apr/24 19:53
• Updated: 16/Apr/24 16:25
• Resolved: 16/Apr/24 16:22

Description

In node.py __environment_variables is generally always set with a map that is passed in from cluster.py so it is shared between nodes and if nodes modify the map, such as in start when updating the Java version then when get_env runs it will overwrite the Java version that is selected by update_java_version.

This results in nodetool drain failing when upgrading from 3.11 to 4.0 in some of the upgrade tests because after the first node upgrades to 4.0 it's not longer possible for the subsequent nodes to select a Java version that isn't 11 because it's overridden by __environment_variables.

I'm not even 100% clear on why the code in start should update __environment_variables at all if we calculate the correct java version on every invocation of other tools.

Issue Links

• links to: ccm PR