[CASSANDRA-19485] if max_hints_size_per_host < max_hints_file_size then it will write hints after max_hints_size_per_host is reached

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Resolved
• Component/s: Consistency/Hints
• Platform: All
• Assignee: Unassigned
• Reporter: Stefan Miklosovic
• Created: 21/Mar/24 09:42
• Updated: 25/Mar/24 13:37
• Resolved: 25/Mar/24 13:36

Description

there is one problem in the current solution being that if we have this config

max_hints_size_per_host: 2MiB
max_hints_file_size: 128MiB

 

basically, max size > size per host, then it will not stop it from writing hints after 2MiB for a particular node, because HintsDescriptor is added among dispatching ones after writer is closed, which happens after there is 128MiB written (all logic in HintsStore), so it will not be included into total sizes, it will be 0 until at least one hints file for that node is written to disk.

I consider this to be the flaw of CASSANDRA-17142, however it is questionable if this is serious enough to deal with in the first place, I don't think somebody would set it up in practice to these values, normally one puts there like max per host is few gigs so this problem is not so visible but it shows in tests almost instantly and it is technically just wrong, regardless of the probability this would happen in real ...

cc yifanc

Issue Links

• is fixed by: CASSANDRA-19477 Do not go to disk to get HintsStore.getTotalFileSize