[CASSANDRA-19461] SAI does not index empty bytes even for types that allow empty bytes as a valid input

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-rc1, 5.0, 5.1
• Component/s: Feature/SAI
• Epic Link: Storage Attached Indexes (Phase 3)
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Critical
• Complexity: Normal
• Discovered By: Fuzz Test
• Platform: All
• Since Version: 5.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/46acaf22e688e7a2e707ac61fd88c96ed33b60d7

Test and Documentation Plan

• new tests around empty text values for literal indexes through the write lifecycle
• new general randomized tests for supported index data types

• Assignee: Caleb Rackliffe
• Reporter: Caleb Rackliffe

Authors

Caleb Rackliffe, David Capwell

Reviewers

David Capwell

• Created: 07/Mar/24 17:22
• Updated: 26/Mar/24 10:38
• Resolved: 22/Mar/24 17:00

Description

This is easy to reproduce with a test that looks something like this:

@Test
public void testEmptyString()
{
    createTable("CREATE TABLE %s (k TEXT PRIMARY KEY, v text)");
    createIndex(String.format(CREATE_INDEX_TEMPLATE, 'v'));

    execute("INSERT INTO %s (k, v) VALUES ('0', '')");
    execute("INSERT INTO %s (k) VALUES ('1')");
    
    // flush(); <---- there is not always a memtable index involved, a fix will have to pay attention to this

    List<Row> rows = executeNet("SELECT * FROM %s WHERE v = ''").all();
    assertEquals(1, rows.size()); <— FAILS! No matches...
}

Issue Links

• links to: GitHub Pull Request #3185
• links to: GitHub Pull Request #3195