[CASSANDRA-19218] NettyStreamingConnectionFactory lacks handling of outcomes other than success

• Type: Bug
• Status: Triage Needed
• Priority: Low
• Resolution: Unresolved
• Fix Version/s: 4.1.x, 5.0.x, 5.1
• Component/s: Legacy/Streaming and Messaging
• Bug Category: Code - Bug - Unclear Impact
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.1.0
• Assignee: Unassigned Assign to me
• Reporter: Jacek Lewandowski
• Created: 21/Dec/23 10:50
• Updated: 21/Dec/23 10:51

Description

This is not a critical issue, but the errors thrown when we try to connect with incompatible messaging version (for example from an sstable loader) are odd. We get weird looking class cast exceptions like this:

{format}
Session peer /127.0.0.1:7012 Failed because of an unknown exception
java.lang.ClassCastException: class org.apache.cassandra.net.OutboundConnectionInitiator$Result$Incompatible cannot be cast to class org.apache.cassandra.net.OutboundConnectionInitiator$Result$Success (org.apache.cassandra.net.OutboundConnectionInitiator$Result$Incompatible and org.apache.cassandra.net.OutboundConnectionInitiator$Result$Success are in unnamed module of loader 'app')
org.apache.cassandra.net.OutboundConnectionInitiator$Result.success(OutboundConnectionInitiator.java:520)
org.apache.cassandra.streaming.async.NettyStreamingConnectionFactory.connect(NettyStreamingConnectionFactory.java:68)
{format}

We should probably handle that somehow and error out with a reasonable message, which at least would prove that we consciously refuse to connect.