[CASSANDRA-19205] Fix flaky test: org.apache.cassandra.tools.BulkLoaderTest.testBulkLoader_WithArgs1-_jdk17

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.12, 4.1.4, 5.0-rc1, 5.0, 5.1
• Component/s: Tool/bulk load
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/290a5990d4ca9d696c490eb717c35d094a23c4cb

Test and Documentation Plan

The issue seems analogous to CASSANDRA-19000, a different test in the same class.
However, we never managed to reproduce it in CircleCI for any of the tests in the test class in thousands of runs, so that is new.
Suggested patch here.
Repeated test run without and with the patch (2000 times each) does not reproduce the issue.

• Assignee: Ekaterina Dimitrova
• Reporter: Brandon Williams

Authors

Ekaterina Dimitrova

Reviewers

Berenguer Blasi

• Created: 15/Dec/23 17:01
• Updated: 26/Mar/24 10:38
• Resolved: 10/Jan/24 18:35

Description

Seen here: https://app.circleci.com/pipelines/github/driftx/cassandra/1418/workflows/5d108993-69f8-4bb8-a616-93a1d904ff1a/jobs/67177/tests

junit.framework.AssertionFailedError: Wrong thread status, active threads unaccounted for: [cluster2-nio-worker-2]
at org.apache.cassandra.tools.OfflineToolUtils.assertNoUnexpectedThreadsStarted(OfflineToolUtils.java:120)
at org.apache.cassandra.tools.BulkLoaderTest.testBulkLoader_WithArgs1(BulkLoaderTest.java:97)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Looks like either a thread is hanging around too long or we need to except it.

Issue Links

• relates to: CASSANDRA-19000 Test Failure: org.apache.cassandra.tools.BulkLoaderTest.testBulkLoader_WithArgs2