[CASSANDRA-19169] Don't NPE when initializing CFSs for local system keyspaces with UCS

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.1-alpha1
• Component/s: Transactional Cluster Metadata
• Epic Link: CEP-21: Follow Up
• Bug Category: Correctness - Recoverable Corruption / Loss
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/8d6d1774e4008263bb381ae9d6b14b8f10f12fca

Test and Documentation Plan

Full CI run

• Assignee: Sam Tunnicliffe
• Reporter: Sam Tunnicliffe

Authors

Sam Tunnicliffe

Reviewers

Alex Petrov

• Created: 05/Dec/23 19:00
• Updated: 07/Dec/23 17:17
• Resolved: 07/Dec/23 17:17

Description

When UnifiedCompactionStrategy is used as the default, NPEs are thrown when
flushing the system keyspace tables early during startup. The system keyspace is
initialised before the cluster metadata, but UCS currently tries to access the
current epoch when initialising the shard manager, to determine whether the
local ranges are out of date. This isn't necessary for the system keyspaces as
they use LocalStrategy and cover the whole token space.