[CASSANDRA-19042] Repair fuzz tests fail with paxos_variant: v2

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-rc1, 5.0, 5.1
• Component/s: Consistency/Repair, Feature/Lightweight Transactions, Test/fuzz
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 5.1-beta

Source Control Link

https://github.com/apache/cassandra/commit/ca0b77d7434aa75528e0cb625889825d29c5f122

Test and Documentation Plan

updated tests

• Assignee: David Capwell
• Reporter: Branimir Lambov

Authors

David Capwell

Reviewers

Blake Eggleston, Ekaterina Dimitrova

• Created: 21/Nov/23 12:23
• Updated: 18/Jul/24 21:11
• Resolved: 26/Mar/24 20:05

Description

Adding paxos_variant: v2 to the test yaml causes all fuzz repair tests to fail with

java.lang.NullPointerException: null
	at org.apache.cassandra.gms.EndpointStateSerializer.serializedSize(EndpointState.java:337)
	at org.apache.cassandra.gms.EndpointStateSerializer.serializedSize(EndpointState.java:300)
	at org.apache.cassandra.service.paxos.cleanup.PaxosStartPrepareCleanup$RequestSerializer.serializedSize(PaxosStartPrepareCleanup.java:176)
	at org.apache.cassandra.service.paxos.cleanup.PaxosStartPrepareCleanup$RequestSerializer.serializedSize(PaxosStartPrepareCleanup.java:147)
	at org.apache.cassandra.net.Message$Serializer.payloadSize(Message.java:1067)
	at org.apache.cassandra.net.Message.payloadSize(Message.java:1114)
	at org.apache.cassandra.net.Message$Serializer.serializedSize(Message.java:750)
	at org.apache.cassandra.net.Message.serializedSize(Message.java:1094)
...

This happens for all three options of paxos_state_purging and both with and without storage_compatibility_mode: NONE.

Tests still fail if PaxosStartPrepareCleanup is changed to use EndpointState.nullableSerializer.

Issue Links

• Discovered while testing: CASSANDRA-18753 Add an optimized default configuration to tests and make it available for new users
• is related to: CASSANDRA-19043 RepairJobTest fails with paxos_variant: v2
• links to: GH: 5.0
• links to: GH: trunk
• links to: GitHub Pull Request #3100