[CASSANDRA-19014] repair_admin summarize-pending command is throwing OpenDataException

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.12, 4.1.4, 5.0-beta1, 5.1
• Component/s: Tool/nodetool
• Bug Category: Code
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 4.0

Source Control Link

https://github.com/apache/cassandra/commit/9affcf169f08faf696f285c28a098daf9bb97b79

Test and Documentation Plan

utests, CI

• Assignee: Szymon Miezal
• Reporter: Szymon Miezal

Authors

Szymon Miezal

Reviewers

Brandon Williams, Stefan Miklosovic

• Created: 09/Nov/23 13:09
• Updated: 29/Nov/23 17:47
• Resolved: 29/Nov/23 17:46

Description

Execution of repair_admin summarize-pending is throwing the following exception:

error: Item names do not match CompositeType: names in items but not in CompositeType: []; names in CompositeType but not in items: [failed]
-- StackTrace --
javax.management.openmbean.OpenDataException: Item names do not match CompositeType: names in items but not in CompositeType: []; names in CompositeType but not in items: [failed]
        at javax.management.openmbean.CompositeDataSupport.<init>(CompositeDataSupport.java:220)
        at javax.management.openmbean.CompositeDataSupport.<init>(CompositeDataSupport.java:176)
        at org.apache.cassandra.repair.consistent.admin.PendingStats.toComposite(PendingStats.java:86)
        at org.apache.cassandra.service.ActiveRepairService.getPendingStats(ActiveRepairService.java:296)
        at org.apache.cassandra.tools.nodetool.RepairAdmin$SummarizePendingCmd.execute(RepairAdmin.java:112)
        at org.apache.cassandra.tools.NodeTool$NodeToolCmd.runInternal(NodeTool.java:358)
        at org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:343)
        at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:246)
        at org.apache.cassandra.distributed.impl.Instance$DTestNodeTool.execute(Instance.java:996)
        at org.apache.cassandra.distributed.impl.Instance.lambda$nodetoolResult$40(Instance.java:906)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.lang.Thread.run(Thread.java:750) 

The bug is caused by the fact that the list of fields at https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/consistent/admin/PendingStats.java#L78-L82 does not align with https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/consistent/admin/PendingStats.java#L35.

Issue Links

• links to: GitHub Pull Request #2942