[CASSANDRA-19001] Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-beta2, 5.0, 5.1
• Component/s: Local/Other
• Bug Category: Packaging
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 5.0-alpha1

Source Control Link

To https://github.com/apache/cassandra.git 8fd44ca8fc..9f5e45e5a2 cassandra-5.0 -> cassandra-5.0 03f0d37cb0..aa644c9dfa trunk -> trunk

Test and Documentation Plan

https://github.com/apache/cassandra/pull/3050/files 5.0
The patch for trunk will be the same

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Ekaterina Dimitrova, Paulo Motta

• Created: 04/Nov/23 17:46
• Updated: 26/Mar/24 10:38
• Resolved: 22/Jan/24 16:30

Description

During the 5.0 alpha 2 release vote, paulo raised the following concerns:

Launched a tarball-based 5.0-alpha2 container on top of
"eclipse-temurin:17-jre-focal" and the server starts up fine, can run
nodetool and cqlsh.
I got these seemingly harmless JDK17 warnings during startup and when
running nodetool (no warnings on JDK11):
WARNING: Unknown module: jdk.attach specified to --add-exports
WARNING: Unknown module: jdk.compiler specified to --add-exports
WARNING: Unknown module: jdk.compiler specified to --add-opens
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by
org.apache.cassandra.security.ThreadAwareSecurityManager
(file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of
org.apache.cassandra.security.ThreadAwareSecurityManager
WARNING: System::setSecurityManager will be removed in a future release
Anybody knows if these warnings are legit/expected ? We can create
follow-up tickets if needed.
$ java --version
openjdk 17.0.9 2023-10-17
OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
sharing)

Clarification: - When running nodetool only the "Unknown module" warnings show up. All warnings show up during startup.

We need to verify whether this presents a real problem in the features where those modules are expected to be used, or if it is a false alarm. 

 

Issue Links

• relates to: CASSANDRA-18711 Replace intercepting System.exit by a custom SecurityManager with something else
• Testing discovered: CASSANDRA-19283 Update rpm and debian shell includes
• links to: GitHub Pull Request #3050