Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-18935

Fix nodetool enable/disablebinary to correctly set rpc

    XMLWordPrintableJSON

Details

    Description

       

              if ((nativeFlag != null && Boolean.parseBoolean(nativeFlag)) || (nativeFlag == null && DatabaseDescriptor.startNativeTransport()))
        {
            startNativeTransport();
            StorageService.instance.setRpcReady(true);
        }

      The startup code here only sets RpcReady if native transport is enabled. If you call 

      nodetool enablebinary

      then this flag doesn't get set.

      But with the change from CASSANDRA-13043 it requires RpcReady set to true in order to get a leader for the counter update.

      Not sure what the correct fix is here, seems to only really use this flag for counters. So thinking perhaps the fix is to just move this outside the if condition.

       

      Attachments

        1. 18935-3.11.patch
          1.0 kB
          Cameron Zemek
        2. image-2023-11-16-10-56-16-693.png
          72 kB
          Runtian Liu
        3. signature.asc
          0.5 kB
          miklosovic

        Activity

          People

            smiklosovic Stefan Miklosovic
            cam1982 Cameron Zemek
            Stefan Miklosovic
            Brandon Williams
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 40m
                2h 40m