[CASSANDRA-18927] Fix potential race condition in IndexViewManager during invalidation

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-beta1, 5.0, 5.1
• Component/s: Feature/SAI
• Epic Link: Storage Attached Indexes (Phase 2)
• Platform: All
• Assignee: Mike Adamson
• Reporter: Mike Adamson

Authors

Mike Adamson

• Created: 12/Oct/23 10:50
• Updated: 21/Nov/23 14:57
• Resolved: 20/Nov/23 10:09

Description

There is a potential race condition in the IndexViewManager.invalidate method:

public void invalidate()
{
    View currentView = view.get();

    for (SSTableIndex index : currentView)
    {
        index.markObsolete();
    }

    view.set(new View(context, Collections.emptyList()));
} 

We should getAndSet the view before marking the indexes as obsolete. This would avoid indexes potentially being made obsolete when being accessed. 

Issue Links

• is fixed by: CASSANDRA-18715 Add support for vector search in SAI