[CASSANDRA-18926] SAI in-memory index does not include maximum term size check when adding terms

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-beta1, 5.0, 5.1
• Component/s: Feature/SAI
• Epic Link: Storage Attached Indexes (Phase 2)
• Bug Category: Correctness - API / Semantic Definition
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 5.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/91a242fe00c9cc740d6d80df61240eebf05f4458

Test and Documentation Plan

PR	CI
5.0	j11 j17
trunk	j11 j17

• Assignee: Andres de la Peña
• Reporter: Mike Adamson

Authors

Andres de la Peña, Zhao Yang

Reviewers

Zhao Yang

• Created: 12/Oct/23 10:39
• Updated: 21/Nov/23 14:57
• Resolved: 20/Nov/23 16:12

Description

The SSTableIndexWriter rejects terms that exceed a maximum term size with a no-spam warning, but the TrieMemoryIndex does not do this. 

We should check term sizes when rows are added and issue client warnings when this happens. This still needs to happen in the SSTableIndexWriter to handle terms during an initial index build. 

Issue Links

• links to: GitHub Pull Request #2918
• links to: GitHub Pull Request #2920