[CASSANDRA-18892] Distributed tests can return ordering columns that have not been selected

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.12, 4.1.4, 5.0, 5.1
• Component/s: Test/dtest/java
• Bug Category: Correctness - Test Failure
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: DTest
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/9697be1131bd8bb2332199000ad55dad12524fd2

Test and Documentation Plan

This is fix the in-tree distributed test code so adds a single test to confirm the fix.

The current test run against 5.0 is here:  https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/297/workflows/c41159b6-57f2-4bce-a238-68e52b43fc2c

• Assignee: Mike Adamson
• Reporter: Mike Adamson

Authors

Mike Adamson

Reviewers

Andres de la Peña, Jeremiah Jordan

• Created: 28/Sep/23 15:46
• Updated: 30/Oct/23 13:19
• Resolved: 30/Oct/23 13:19

Description

The following test fails

@Test
public void incorrectClusteringColumnTest() throws IOException
{
    try (Cluster cluster = init(Cluster.build(1).start()))
    {
        cluster.schemaChange(withKeyspace("CREATE TABLE %s.t (k int, c int, v int, primary key(k, c))"));

        cluster.coordinator(1).execute(withKeyspace("INSERT INTO %s.t (k, c, v) VALUES (0, 1, 2)"), ConsistencyLevel.QUORUM);

        String query = withKeyspace("SELECT v FROM %s.t WHERE k IN (0, 1) ORDER BY c LIMIT 10");
        assertRows(cluster.coordinator(1).execute(query, ConsistencyLevel.ONE), row(2));
    }
}
 

The query is returning the clustering column c as well as the regular column v.

The reason for the extra column being returned is that the RowUtil is using ResultMessage.Rows.result.metadata.names instead on ResultMessage.Rows.result.metadata.requestNames(). This last method removes columns that have not been requested.