[CASSANDRA-18879] Modernize CQLSH datetime conversions - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Low
Resolution: Fixed
Fix Version/s: 5.1-alpha1, 5.1
Component/s: CQL/Interpreter
Labels:
None

Change Category:
Code Clarity
Complexity:
Low Hanging Fruit
Platform:

All
Impacts:

None
Source Control Link:

https://github.com/apache/cassandra/commit/bfb5c593429c1bb615426ec2d35c1c27c7f81488
Test and Documentation Plan:

Hide

Tested it manually.

My timezone is US/Eastern. You can see the tracing output showing the time (2024-01-16 16:18:43.599000-05:00) in my timezone and the table containing the time in UTC (2024-01-16 21:18:43.599000+0000).

(See attached log file)

Show
Tested it manually. My timezone is US/Eastern. You can see the tracing output showing the time ( 2024-01-16 16:18:43.599000-05:00 ) in my timezone and the table containing the time in UTC ( 2024-01-16 21:18:43.599000+0000 ). (See attached log file )

Description

Python 3.x introduced many updates to datetime conversion which allows simplified conversions.

1. For example, tracing.py defines a function datetime_from_utc_to_local() but datetime now has a native function astimezone() which will convert UTC to local time.

Review the following users of datetime which apply conversions:

cqlshmain.py
formatting.py
tracing.py

Example:

>>> from dateutil import tz
>>> import datetime
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705, tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EST'))

See [PEP 495]