[CASSANDRA-18864] CIDR permission cache probably does not work

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Duplicate
• Bug Category: Correctness - Consistency
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 5.0-alpha1
• Assignee: Unassigned Assign to me
• Reporter: Jacek Lewandowski
• Created: 18/Sep/23 12:32
• Updated: 18/Sep/23 12:38
• Resolved: 18/Sep/23 12:38

Description

CIDR permission cache code:

    /**
     * Invalidate a role from CIDR permissions cache
     * @param roleName role for which to invalidate the cache
     * @return boolean returns true if given role found in the cache and invalidated, otherwise returns false
     */
    public boolean invalidateCidrPermissions(String roleName)
    {
        if (cache.getIfPresent(roleName) == null)
            return false;

        invalidate(RoleResource.role(roleName));
        return true;
    }

passes String role name to the cache and if it returns null it just returns false. It will always return null because cache expects objects of type RoleResource.

Issue Links

• duplicates: CASSANDRA-18805 Upgrade caffeine to 3.1.8 and fix CIDR permissions cache invalidation