[CASSANDRA-18840] Leakage of references to SSTable on unsuccessful operations

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0, 5.1
• Component/s: Local/SSTable
• Bug Category: Degradation
• Severity: Normal
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 5.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/15f355a0062148e1ca511e8fc515e0cba380790d

Test and Documentation Plan

regression

• Assignee: Jacek Lewandowski
• Reporter: Stefan Miklosovic

Authors

Jacek Lewandowski

Reviewers

Stefan Miklosovic

• Created: 12/Sep/23 12:21
• Updated: 26/Jan/24 10:03
• Resolved: 15/Sep/23 07:28

Description

This is a little bit tricky to describe correctly as I can talk about the symptoms only. I hit this issue when testing CASSANDRA-18781.

In a nutshell, when we go to bulkload an SSTable, it opens it in SSTableLoader. If bulkloading fails on server side and exception is propagated to the client, on releasing of references, it fails on this assert (1). This practically means that we are leaking resources as something still references that SSTable but it was not tidied up (on failure). On a happy path, it is all de-referenced correctly.

I think that this might have implications beyond SSTable loading, e.g. this could happen upon streaming too.

(1) https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableLoader.java#L245

Issue Links

• blocks: CASSANDRA-18781 Add the ability to disable bulk loading of SSTables on a node
• links to: GitHub Pull Request #2681
• links to: GitHub Pull Request #2685