[CASSANDRA-18756] TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps overlaping SSTable references

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.11.17, 4.0.12, 4.1.4, 5.0-alpha2, 5.0, 5.1
• Component/s: Local/Compaction
• Bug Category: Degradation - Resource Management
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 3.11.1

Source Control Link

https://github.com/apache/cassandra/pull/2656

Test and Documentation Plan

CI

• Assignee: Ethan Brown
• Reporter: Branimir Lambov

Authors

Ethan Brown

Reviewers

Branimir Lambov, Michael Semb Wever

• Created: 15/Aug/23 12:48
• Updated: 01/Nov/23 08:54
• Resolved: 21/Sep/23 14:26

Description

When unsafe_aggressive_sstable_expiration is turned on, TWCS should not create or maintain an iterator of overlapping sstables. However, because TimeWindowCompactionController inherits from CompactionController and only sets ignoreOverlaps after the base class has constructed the overlap iterator, it ends up making an overlap iterator and then never updating it.

The end result is that such a compaction keeps references to lots of and likely all other SSTables on the node and thus delays the deletion of obsolete ones by hours or even days.

Issue Links

• is caused by: CASSANDRA-13418 Allow TWCS to ignore overlaps when dropping fully expired sstables
• links to: GitHub Pull Request #2656