[CASSANDRA-18627] Tidy up vestigial code left over after CASSANDRA-17931

• Type: Bug
• Status: In Progress
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 5.x
• Component/s: Consistency/Repair, Local/Compaction
• Bug Category: Degradation
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All

Test and Documentation Plan

No new testing; confirm existing tests pass.

• Assignee: Josh McKenzie
• Reporter: Josh McKenzie

Authors

Josh McKenzie

• Created: 26/Jun/23 18:50
• Updated: 26/Jun/23 21:24

Description

In CASSANDRA-17931, some code was left over (additionalBytes, additionalSSTables) inside the PendingRepairManager which, while not explicitly hurting anything, provides for some confusion around when we do or don't take additional values into account when adjusting for pending operations when deciding what to do with upcoming repairs etc.

 

We should tidy that up and consider making the role of those methods / their structure more clear between the {

{PendingRepairManager]}

hierarchy and the AbstractCompactionStrategy hierarchy to prevent further confusion.