[CASSANDRA-18617] Disable the deprecated keyspace/table thresholds and convert them to Guardrails

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Feature/Guardrails
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/aac070681bd01ba796814692c3fba04de103d8b4

Test and Documentation Plan

PR	CI
trunk	j8 j11

 

• Assignee: dan jatnieks
• Reporter: dan jatnieks

Authors

dan jatnieks

Reviewers

Andres de la Peña, Brandon Williams

• Created: 21/Jun/23 17:36
• Updated: 12/Sep/23 13:02
• Resolved: 14/Jul/23 11:29

Description

The non-guardrail thresholds 'keyspace_count_warn_threshold' and 'table_count_warn_threshold' configuration settings were first added with CASSANDRA-16309 in 4.0-beta4 and have subsequently been deprecated since 4.1-alpha in CASSANDRA-17195 when they were replaced/migrated to guardrails as part of CEP-3 (Guardrails).

These thresholds should now be removed from cassandra.yaml, while still allowed in existing yaml files.

The old thresholds will be disabled by removing their default values from Config.java, and any existing values for these thresholds will be converted to the new guardrails using the '@Replaces' tag on the corresponding guardrail values.

Since the old thresholds considered the number of system keyspace/tables in their values, the '@Replaces' conversion will subtract the current number of system tables from the old value and log a descriptive message.

See dev list discussion: https://lists.apache.org/thread/0zjg08hrd6xv7lhvo96frz456b2rvr8b

Issue Links

• links to: GitHub Pull Request #2467