[CASSANDRA-18585] Alter Type does not validate changes like Create Type does - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 3.0.30, 3.11.17, 4.0.12, 4.1.4, 5.0-alpha1, 5.0
Component/s: Cluster/Schema
Labels:
None

Bug Category:
Correctness - Unrecoverable Corruption / Loss
Severity:
Critical
Complexity:
Low Hanging Fruit
Discovered By:
Code Inspection
Platform:

All
Impacts:

None
Since Version:

3.0.0
Source Control Link:

https://github.com/apache/cassandra/commit/4ab31d34c86d1b387098dd7934b11c659c763416
Test and Documentation Plan:

Hide

Added a unit test that showcases the issue

Show
Added a unit test that showcases the issue

Description

Create Type attempts to block undesired field types, but this validation is not cared over to Alter Type Add Field; which allows you to add unexpected/desired types

Assertions.assertThatThrownBy(() -> createType("CREATE TYPE %s (f counter)")).hasRootCauseMessage("A user type cannot contain counters");
String type = createType(KEYSPACE, "CREATE TYPE %s (a int)");
schemaChange(String.format("ALTER TYPE %s.%s ADD f counter", KEYSPACE, type));
UserType udt = Keyspace.open(KEYSPACE).getMetadata().types.get(UTF8Type.instance.decompose(type)).get();
logger.warn("UDT: {}", udt);

UDT: org.apache.cassandra.db.marshal.UserType(cql_test_keyspace,747970655f3031,61:org.apache.cassandra.db.marshal.Int32Type,66:org.apache.cassandra.db.marshal.CounterColumnType)