[CASSANDRA-18474] Incremental repairs fail on mixed IPv4/v6 addresses serializing SyncRequest

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.10, 4.1.2, 5.0-alpha1, 5.0
• Component/s: Consistency/Repair, Messaging/Internode
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/09c1e67598d7a0dc7da7bebee358fbc96d84680a

Test and Documentation Plan

Change is the same for all branches. Just made a single PR here.
https://github.com/apache/cassandra/pull/2288

CI Results (pending):

Branch	Source	Circle CI	Jenkins
cassandra-4.0	branch	build	build
cassandra-4.1	branch	build	build
trunk	branch	build	build

• Assignee: Jon Meredith
• Reporter: Jon Meredith

Authors

Jon Meredith

Reviewers

Caleb Rackliffe

• Created: 21/Apr/23 21:10
• Updated: 12/Sep/23 13:03
• Resolved: 25/Apr/23 18:19

Description

The SyncRequest message assumes the initiator/src/dst are all the IP address
type as an optimization when calculating serialized size. It needs to handle mixed address families.

/1.2.3.4:7000->/[::1]:7000-SMALL_MESSAGES-f83ce0bc dropping message of type SYNC_REQ due to error"

{Exception}

org.apache.cassandra.net.InvalidSerializedSizeException: Invalid serialized size; expected 158, actual size at least 170, for verb SYNC_REQ
        at org.apache.cassandra.net.OutboundConnection$EventLoopDelivery.doRun(OutboundConnection.java:816)
        at org.apache.cassandra.net.OutboundConnection$Delivery.run(OutboundConnection.java:687)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)

Issue Links

• links to: GitHub Pull Request #2288