Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-1847

ByteBufferUtil.clone shouldn't mutate the passed bytebuffer

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 0.7.0 rc 3
    • None
    • None
    • Low

    Description

      Currently ByteBufferUtil.clone uses .mark and .reset on the passed ByteBuffer.

      This is fine when using thrift because no two ByteBuffer are being accessed at the same time, but this could be thread-unsafe if the same BB was passed concurrently.

      Solandra is having problems with this (Solandra shares JVM with Cassandra).

      Attachments

        1. 1847-v4.txt
          1 kB
          Jonathan Ellis
        2. 1847-v3.txt
          1 kB
          T Jake Luciani
        3. 1847-v2.txt
          1 kB
          Jonathan Ellis
        4. 1847_v1.txt
          0.9 kB
          T Jake Luciani

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tjake T Jake Luciani Assign to me
            tjake T Jake Luciani
            T Jake Luciani
            Jonathan Ellis
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment