[CASSANDRA-18466] Paxos only repair is treated as an incremental repair

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1.4, 5.0-alpha2, 5.0, 5.1
• Component/s: Consistency/Repair
• Labels: lhf
• Bug Category: Correctness
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.1.0

Source Control Link

https://github.com/apache/cassandra/commit/725655dda2776fef35567496a6e331102eb7610d

Test and Documentation Plan

Test on CI

• Assignee: Ningzi Zhan
• Reporter: Andrew

Authors

Ningzi Zhan

Reviewers

Brandon Williams, Jacek Lewandowski, Maxwell Guo

• Created: 19/Apr/23 15:04
• Updated: 12/Sep/23 12:58
• Resolved: 08/Sep/23 14:10

Description

Paxos only repair tries to continue or is treated as an incremental repair. This happened on 4.1.0 and 4.1.1 when trying to run repair in preparation for enabling paxos_state_purging. The repair was in preparation mode triggered multiple anti-compactions on the nodes. Running the command with --full behaves in the expected way, ie. only the paxos data is repaired and it's finished within a few seconds.

nodetool repair --paxos-only // This does not behave as expected, does it complete quickly and seems to be waiting on anticompactions

nodetool repair --full --paxos-only // Completes within a few seconds as expected

Issue Links

• links to: GitHub Pull Request #2531