[CASSANDRA-18453] Use WithProperties to ensure that system properties are handled

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: CI
• Labels: low-hanging-fruit
• Change Category: Code Clarity
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/ffe4d85df23e22be78b8047e91e4a065c5c73c06

Test and Documentation Plan

Added the patch

• Assignee: Bernardo Botella Corbi
• Reporter: Maxim Muzafarov

Authors

Bernardo Botella Corbi

Reviewers

Jacek Lewandowski, Maxim Muzafarov, Stefan Miklosovic

• Created: 17/Apr/23 12:59
• Updated: 12/Sep/23 13:02
• Resolved: 26/May/23 16:32

Description

The WithProperties is used to handle system properties to set and reset values during the test run, instead of try-catch it uses the try-with-resource approach which facilitates test development.

We need to replace all the try-catch clauses that work with system properties with WithProperties and try-with-resource for all the similar cases and where it is technically possible.

Example:

        try
        {
            COMMITLOG_IGNORE_REPLAY_ERRORS.setBoolean(true);
            testRecoveryWithGarbageLog();
        }
        finally
        {
            COMMITLOG_IGNORE_REPLAY_ERRORS.clearValue();
        }

Can be replaced with:

        try (WithProperties = new WithProperties().with(COMMITLOG_IGNORE_REPLAY_ERRORS, "true"))
        {
            testRecoveryWithGarbageLog();
        }

Issue Links

• links to: GitHub Pull Request #2352