[CASSANDRA-18439] Revert some accesses to internals after CASSANDRA-18329 lands - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Task
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 5.0-alpha1, 5.0, 5.1
Component/s: Jamm
Labels:
None

Epic Link:
Support Java 17
Change Category:
Semantic
Complexity:
Normal
Platform:

All
Impacts:

None
Source Control Link:

https://github.com/apache/cassandra/commit/ae8abf5cd62e2f99c981700a1f8aa9d3a71d80ee. https://github.com/apache/cassandra/commit/4621ec77821c306de448e6826f46551d75e7ec18
Test and Documentation Plan:
Hide

I updated the two files and build.xml, which adds the jvmargs needed during testing, here:

https://github.com/apache/cassandra/pull/2638

CI J17 all possible tests:https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2486/workflows/2c186c13-a508-4df7-969f-40b69ec1e2af

There is a single test that failed due to JVM crash, which I did not find any information about:

[junit-timeout] # A fatal error has been detected by the Java Runtime Environment: [junit-timeout] # [junit-timeout] # SIGSEGV (0xb) at pc=0x00007ff74136f654, pid=1479, tid=1484 [junit-timeout] # [junit-timeout] # JRE version: OpenJDK Runtime Environment (17.0.7+7) (build 17.0.7+7-Ubuntu-0ubuntu120.04) [junit-timeout] # Java VM: OpenJDK 64-Bit Server VM (17.0.7+7-Ubuntu-0ubuntu120.04, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64) [junit-timeout] # Problematic frame: [junit-timeout] # V [libjvm.so+0xbbe654] Method::is_method_handle_intrinsic() const+0x4 [junit-timeout] # [junit-timeout] # Core dump will be written. Default location: /tmp/cassandra/core.1479.%E [junit-timeout] # [junit-timeout] # An error report file with more information is saved as: [junit-timeout] # /tmp/cassandra/hs_err_pid1479.log [junit-timeout] Compiled method (c2) 101528 17232 4 (method) [junit-timeout] total in heap [0x00007ff72d5c4d90,0x00007ff72d5c53f8] = 1640 [junit-timeout] relocation [0x00007ff72d5c4ef0,0x00007ff72d5c4f28] = 56 [junit-timeout] main code [0x00007ff72d5c4f40,0x00007ff72d5c5160] = 544 [junit-timeout] stub code [0x00007ff72d5c5160,0x00007ff72d5c5188] = 40 [junit-timeout] oops [0x00007ff72d5c5188,0x00007ff72d5c51a0] = 24 [junit-timeout] metadata [0x00007ff72d5c51a0,0x00007ff72d5c5200] = 96 [junit-timeout] scopes data [0x00007ff72d5c5200,0x00007ff72d5c5320] = 288 [junit-timeout] scopes pcs [0x00007ff72d5c5320,0x00007ff72d5c53c0] = 160 [junit-timeout] dependencies [0x00007ff72d5c53c0,0x00007ff72d5c53d0] = 16 [junit-timeout] handler table [0x00007ff72d5c53d0,0x00007ff72d5c53e8] = 24 [junit-timeout] nul chk table [0x00007ff72d5c53e8,0x00007ff72d5c53f8] = 16 [junit-timeout] Compiled method (c2) 101530 11584 4 (method) [junit-timeout] total in heap [0x00007ff72d434590,0x00007ff72d4347f8] = 616 [junit-timeout] relocation [0x00007ff72d4346f0,0x00007ff72d434700] = 16 [junit-timeout] main code [0x00007ff72d434700,0x00007ff72d434760] = 96 [junit-timeout] stub code [0x00007ff72d434760,0x00007ff72d434778] = 24 [junit-timeout] oops [0x00007ff72d434778,0x00007ff72d434788] = 16 [junit-timeout] metadata [0x00007ff72d434788,0x00007ff72d434798] = 16 [junit-timeout] scopes data [0x00007ff72d434798,0x00007ff72d4347c0] = 40 [junit-timeout] scopes pcs [0x00007ff72d4347c0,0x00007ff72d4347f0] = 48 [junit-timeout] dependencies [0x00007ff72d4347f0,0x00007ff72d4347f8] = 8 [junit-timeout] # [junit-timeout] # If you would like to submit a bug report, please visit: [junit-timeout] # Unknown

I tried to reproduce it unsuccessfully here:

https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2488/workflows/1877f74f-7b48-4767-b48f-dc0166d9efc2/jobs/38072
Show
I updated the two files and build.xml, which adds the jvmargs needed during testing, here: https://github.com/apache/cassandra/pull/2638 CI J17 all possible tests: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2486/workflows/2c186c13-a508-4df7-969f-40b69ec1e2af There is a single test that failed due to JVM crash, which I did not find any information about: [junit-timeout] # A fatal error has been detected by the Java Runtime Environment: [junit-timeout] # [junit-timeout] # SIGSEGV (0xb) at pc=0x00007ff74136f654, pid=1479, tid=1484 [junit-timeout] # [junit-timeout] # JRE version: OpenJDK Runtime Environment (17.0.7+7) (build 17.0.7+7-Ubuntu-0ubuntu120.04) [junit-timeout] # Java VM: OpenJDK 64-Bit Server VM (17.0.7+7-Ubuntu-0ubuntu120.04, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64) [junit-timeout] # Problematic frame: [junit-timeout] # V [libjvm.so+0xbbe654] Method::is_method_handle_intrinsic() const +0x4 [junit-timeout] # [junit-timeout] # Core dump will be written. Default location: /tmp/cassandra/core.1479.%E [junit-timeout] # [junit-timeout] # An error report file with more information is saved as: [junit-timeout] # /tmp/cassandra/hs_err_pid1479.log [junit-timeout] Compiled method (c2) 101528 17232 4 (method) [junit-timeout] total in heap [0x00007ff72d5c4d90,0x00007ff72d5c53f8] = 1640 [junit-timeout] relocation [0x00007ff72d5c4ef0,0x00007ff72d5c4f28] = 56 [junit-timeout] main code [0x00007ff72d5c4f40,0x00007ff72d5c5160] = 544 [junit-timeout] stub code [0x00007ff72d5c5160,0x00007ff72d5c5188] = 40 [junit-timeout] oops [0x00007ff72d5c5188,0x00007ff72d5c51a0] = 24 [junit-timeout] metadata [0x00007ff72d5c51a0,0x00007ff72d5c5200] = 96 [junit-timeout] scopes data [0x00007ff72d5c5200,0x00007ff72d5c5320] = 288 [junit-timeout] scopes pcs [0x00007ff72d5c5320,0x00007ff72d5c53c0] = 160 [junit-timeout] dependencies [0x00007ff72d5c53c0,0x00007ff72d5c53d0] = 16 [junit-timeout] handler table [0x00007ff72d5c53d0,0x00007ff72d5c53e8] = 24 [junit-timeout] nul chk table [0x00007ff72d5c53e8,0x00007ff72d5c53f8] = 16 [junit-timeout] Compiled method (c2) 101530 11584 4 (method) [junit-timeout] total in heap [0x00007ff72d434590,0x00007ff72d4347f8] = 616 [junit-timeout] relocation [0x00007ff72d4346f0,0x00007ff72d434700] = 16 [junit-timeout] main code [0x00007ff72d434700,0x00007ff72d434760] = 96 [junit-timeout] stub code [0x00007ff72d434760,0x00007ff72d434778] = 24 [junit-timeout] oops [0x00007ff72d434778,0x00007ff72d434788] = 16 [junit-timeout] metadata [0x00007ff72d434788,0x00007ff72d434798] = 16 [junit-timeout] scopes data [0x00007ff72d434798,0x00007ff72d4347c0] = 40 [junit-timeout] scopes pcs [0x00007ff72d4347c0,0x00007ff72d4347f0] = 48 [junit-timeout] dependencies [0x00007ff72d4347f0,0x00007ff72d4347f8] = 8 [junit-timeout] # [junit-timeout] # If you would like to submit a bug report, please visit: [junit-timeout] # Unknown I tried to reproduce it unsuccessfully here: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2488/workflows/1877f74f-7b48-4767-b48f-dc0166d9efc2/jobs/38072

Description

The current version of JAMM in Cassandra does not handle properly the module system.

To workaround some of the failures we see when starting Cassandra and running tests, a numerous - ~~add-opens~~ and add-exports were added temporarily until Jamm is fixed.

Those need to be revised and potentially reverted.

https://github.com/apache/cassandra/blob/trunk/conf/jvm17-server.options#L94-L107

(potentially also in the jvm11-server.options file too)

https://github.com/apache/cassandra/blob/trunk/conf/jvm17-clients.options#L55-L67

(again, potentially also in jvm11-client.options file too)

~~CASSANDRA-18329~~ should cover jamm upgrade which will happen when new jamm version is released.

Attachments

Issue Links

is blocked by

CASSANDRA-18329 Upgrade jamm; fix eclipse problems

Resolved

Activity

People

Assignee:: Ekaterina Dimitrova

Reporter:: Ekaterina Dimitrova

Authors:: Ekaterina Dimitrova

Reviewers:: Benjamin Lerer

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 10/Apr/23 15:50

Updated:: 12/Sep/23 13:02

Resolved:: 30/Aug/23 14:59