[CASSANDRA-18438] Refactor cloud snitches to get rid of duplicate code

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Local/Other
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/903857b4ef01b577db2cbcf3ea9a9b194dede21c

Test and Documentation Plan

CI

• Assignee: Stefan Miklosovic
• Reporter: Maxwell Guo

Authors

Stefan Miklosovic

Reviewers

Jacek Lewandowski, Jackson Fleming, Maxwell Guo

• Created: 10/Apr/23 03:34
• Updated: 12/Sep/23 13:03
• Resolved: 14/Jul/23 10:40

Description

Nowadays we have got about four public cloud platform snitchs ： EC2 snitch for aws, google cloud snitch for google cloud, alibaba cloud snitch for alibaba cloud and multi region snitch for ec2. And the common place for the first three is that we just need to query the zone center to get the ec2 / ecs id , so I think we can refactor the code , and if some new public cloud platform want to add one more snitch for himself, there is no need to pull a pr for him and configure some options in yaml is enough .
Besides it would be even better that we may reuse the multic region snitch for ec2 for other public cloud platform.

Issue Links

• Dependency: CASSANDRA-16555 Add support for AWS Ec2 IMDSv2
• links to: GitHub Pull Request #2458