[CASSANDRA-18436] Unit tests in org.apache.cassandra.cql3.EmptyValuesTest class occasionally failing with JDK17

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: CI
• Epic Link: Support Java 17
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/5768e5ae41879885e7e2aca79b38bed53df55711

Test and Documentation Plan

Branch	CI
trunk	java17

The test was also run in a loop here

It seems there was an issue with CI setup before as the test does not fail anymore. Suggested patch is just to add a few more assertions to improve the test

• Assignee: dan jatnieks
• Reporter: Ekaterina Dimitrova

Authors

dan jatnieks

Reviewers

Berenguer Blasi, Ekaterina Dimitrova

• Created: 07/Apr/23 18:10
• Updated: 12/Sep/23 13:02
• Resolved: 12/May/23 15:10

Description

 

All of them failed with the below stack trace for the same assertion failing:

junit.framework.AssertionFailedError: at org.apache.cassandra.cql3.EmptyValuesTest.verify(EmptyValuesTest.java:90) at org.apache.cassandra.cql3.EmptyValuesTest.verifyJsonInsert(EmptyValuesTest.java:112) at org.apache.cassandra.cql3.EmptyValuesTest.testEmptyDecimal(EmptyValuesTest.java:192) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

 

Unfortunately I do not have a link to the CI run as this was seen last in private infra and not in CircleCI. Maybe we want to check with the multiplexer for flakiness.