[CASSANDRA-18387] Fix build script for shaded jvm-dtest JAR

• Type: Bug
• Status: Review In Progress
• Priority: Normal
• Resolution: Unresolved
• Component/s: Build, Test/dtest/java
• Bug Category: Packaging - Source Distribution
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All

Test and Documentation Plan

Run ./build-shaded-dtest-jar.sh to confirm build is successful.

• Assignee: Unassigned
• Reporter: Abe Ratnofsky

Authors

Abe Ratnofsky

Reviewers

Caleb Rackliffe

• Created: 28/Mar/23 23:08
• Updated: 04/Apr/23 19:14

Description

On trunk as of 6a5f84d0f44f5562776a12a678c7d68168d2c7e7, ./build-shaded-dtest-jar.sh fails with errors related to org.apache.tools.ant.taskdefs.optional.junit package visibility:

...
    [javac]   symbol:   class JUnitTest
    [javac]   location: class CassandraXMLJUnitResultFormatter
    [javac] /cassandra/test/unit/org/apache/cassandra/JStackJUnitTask.java:27: error: package org.apache.tools.ant.taskdefs.optional.junit does not exist
    [javac] import org.apache.tools.ant.taskdefs.optional.junit.JUnitTask;
    [javac]                                                    ^
    [javac] /cassandra/test/unit/org/apache/cassandra/JStackJUnitTask.java:30: error: cannot find symbol
    [javac] public class JStackJUnitTask extends JUnitTask
    [javac]                                      ^
    [javac]   symbol: class JUnitTask
    [javac] Note: Processing compiler hints annotations
    [javac] Note: Writing compiler command file at META-INF/hotspot_compiler
    [javac] Note: Done processing compiler hints annotations
    [javac] 22 errors

BUILD FAILED
/cassandra/build.xml:999: The following error occurred while executing this line:
/cassandra/build.xml:1012: Compile failed; see the compiler error output for details.

Reproduced with Java 11, Maven 3.5.4, Ant 1.10.5.

This is caused by the classpath exclusion of

${test.lib}/jars/**/ant-*.jar

, which includes ant-junit, which is depended on by org.apache.cassandra.CassandraXMLJUnitResultFormatter.
See: https://github.com/apache/cassandra/blob/6a5f84d0f44f5562776a12a678c7d68168d2c7e7/build.xml#L331

To fix, update to include that library specifically:

         <fileset dir="${test.lib}/jars">
             <include name="**/*.jar" />
             <exclude name="**/ant-*.jar"/>
         </fileset>
+        <fileset dir="${test.lib}/jars">
+            <include name="**/ant-junit-*.jar" />
+        </fileset>