[CASSANDRA-18343] JDK17 - fix nodetool_test.TestNodetool.test_sjk

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: CI
• Epic Link: Support Java 17
• Bug Category: Correctness - Test Failure
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/de1ff6d4d149f4983238ae1d38fd9b9c657bb282

Test and Documentation Plan

Patch, CI run
I ran only the JDK17 tests because the change affects only them. We add the export in the jvm17-clients.options

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Brandon Williams

• Created: 19/Mar/23 19:28
• Updated: 12/Sep/23 13:02
• Resolved: 23/Mar/23 19:11

Description

 
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2321/workflows/de1f521d-c5cb-4ddd-bc45-9ec71b577bf3/jobs/19923/tests
 

AssertionError: Expected 'SJK hh' output assert False == True self = <nodetool_test.TestNodetool object at 0x7f9ab6d95908> @since('4.0') def test_sjk(self): """ Verify that SJK generally works. """ cluster = self.cluster cluster.populate([1]).start() node = cluster.nodelist()[0] out, err, _ = node.nodetool('sjk --help') logger.debug(out) hasPattern = False for line in out.split(os.linesep): if " ttop [Thread Top] Displays threads from JVM process" == line: hasPattern = True assert hasPattern == True, "Expected help about SJK ttop" out, err, _ = node.nodetool('sjk') logger.debug(out) hasPattern = False for line in out.split(os.linesep): if " ttop [Thread Top] Displays threads from JVM process" == line: hasPattern = True assert hasPattern == True, "Expected help about SJK ttop" out, err, _ = node.nodetool('sjk hh -n 10 --live') logger.debug(out) hasPattern = False for line in out.split(os.linesep): if re.match('.*Instances.*Bytes.*Type.*', line): hasPattern = True > assert hasPattern == True, "Expected 'SJK hh' output" E AssertionError: Expected 'SJK hh' output E assert False == True nodetool_test.py:482: AssertionError