[CASSANDRA-18268] Add more logging around CompactionManager operations

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Observability/Logging
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/180f0f0b5b47a48c1a7d88927223cc52871cc801

Test and Documentation Plan

https://github.com/apache/cassandra/pull/2174

• Assignee: Milan Krisko
• Reporter: Kan Maung

Authors

Milan Krisko, Stefan Miklosovic

Reviewers

Brad Schoening, Brandon Williams, Kan Maung

• Created: 16/Feb/23 14:21
• Updated: 12/Sep/23 13:03
• Resolved: 07/Mar/23 20:57

Description

Whenever a cleanup or garbagecollect operation is issued from nodetool, there is no log statuses for the start and end of the operation at the node level although statuses on individual sstables are captured. Start can be inferred, but it is difficult to know when the operation has completed because there is no log message.

 

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:353 - Starting Remove deleted data for keyspace1.sstable1

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:395 - Finished Remove deleted data for keyspace1.sstable1 successfully

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:353 - Starting Remove deleted data for keyspace1.sstable2

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:364 - No sstables to GARBAGE_COLLECT for keyspace1.sstable2

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:395 - Finished Remove deleted data for keyspace1.sstable2 successfully

 

This improvement proposes adding additional for start and end statuses log messages for the above operation at the node level. I.e.,

 

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:395 – Starting GARBAGE_COLLECT

….

[INFO ] cluster_id=5 ip_address=127.1.1.1  CompactionManager.java:395 – Completed GARBAGE_COLLECT