[CASSANDRA-18223] Byteman rule in stop_data_reads.btm cannot compile against accord.messages.ReplyContext

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: NA
• Component/s: Accord
• Labels: byteman dtest python
• Epic Link: CEP-15: Accord Beta
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: DTest
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra-dtest/commit/33ff84a396c9d5b9a9be574be50dbb2ea9c9ded0

Test and Documentation Plan

n/a (test fix)

• Assignee: Youki Shiraishi
• Reporter: Caleb Rackliffe

Authors

Youki Shiraishi

Reviewers

Caleb Rackliffe

• Created: 02/Feb/23 16:50
• Updated: 20/Feb/23 20:47
• Resolved: 20/Feb/23 20:47

Description

The Python read_repair_test relies on a Byteman rule on the doVerb() method in ReadCommandVerbHandler, but accord.messages.ReplyContext isn’t on the classpath. This is probably because we don't include it in the list of jars created in byteman_validate.

AssertionError: byteman script didn't compile
  Checking rule disable data reads against class org.apache.cassandra.db.ReadCommandVerbHandler
  Parsed rule "disable data reads" for class org.apache.cassandra.db.ReadCommandVerbHandler
  ERROR : Failed to check rule "disable data reads" loaded from /home/cassandra/cassandra-dtest/byteman/read_repair/stop_data_reads.btm line 8 against method doVerb(org.apache.cassandra.net.Message) void
  java.lang.NoClassDefFoundError: accord/messages/ReplyContext

ex. https://app.circleci.com/pipelines/github/maedhroz/cassandra/686/workflows/ffd1e528-b8ec-4534-a333-ab450e110e89/jobs/6481/tests#failed-test-0

It might make sense to fix this after CASSANDRA-18204 wraps up, so we know exactly how the Accord library is pulled into C*. Then, once we do fix it, we should fix in a way that still works w/ 4.0 and 4.1, etc. (i.e. Don't assume the Accord library must be present.)

Issue Links

• blocks: CASSANDRA-18196 Initial Merge of Accord Feature Branch to Trunk
• is blocked by: CASSANDRA-18204 CEP-15: (C*) Add git submodule for Accord