[CASSANDRA-18213] CEP-15: (Accord) Migrate Accord away from JDK random to a new interface RandomSource

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Accord
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/ea01634739ef09ceef567259637d07095447b28c

Test and Documentation Plan

migrated all tests

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Blake Eggleston

• Created: 31/Jan/23 22:19
• Updated: 12/Sep/23 13:02
• Resolved: 15/Mar/23 20:31

Description

JDK Random has basic functions needed, but is lacking and requires custom utils to add some added methods desired (such as next[short,int,long,float,double] in a range), so to deal with this we should own the random interface we use.

This has 2 main context points for accord: Node (breaking API change), and BurnTest.

By owning our own interface, we could also have C* Simulator’s RandomSource “extend” it so we don’t have to redefine everything cross both repos.

Issue Links

• depends upon: CASSANDRA-18203 CEP-15: (C*) Improve Burn Tests to include thread scheduling
• links to: CI: accord trunk
• links to: CI: cep-15-accord
• links to: GH: accord trunk
• links to: GH: cep-15-accord
• links to: GitHub Pull Request #2209