[CASSANDRA-18211] NoSuchFileException when removing a snapshot

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1.1, 5.0-alpha1, 5.0
• Component/s: Local/Snapshots
• Bug Category: Code
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.1.0

Source Control Link

https://github.com/apache/cassandra/commit/cfe9641fbec0dc62c9a0f4f156c702e2cfa6ad4e

Test and Documentation Plan

added unit test

• Assignee: Stefan Miklosovic
• Reporter: Jacek Lewandowski

Authors

Stefan Miklosovic

Reviewers

Jacek Lewandowski

• Created: 31/Jan/23 20:24
• Updated: 12/Sep/23 13:03
• Resolved: 17/Feb/23 14:58

Description

Automatic deletion of expired snapshots maintained by SnapshotManager can race with manual snapshot removal in a way an exception like NoSuchFileException is thrown.

It is because the snapshot directory existence is checked and deleted if it exists as a non-atomic operation. Since we can potentially have two threads attempting to do that at the same time (automatic and manual snapshot removal) it may lead to a race in rare situations.

Issue Links

• relates to: CASSANDRA-18271 Centralize all snapshot operations to SnapshotManager