[CASSANDRA-18152] mockito-inline causes tests to fail beacause o.a.c.distributed.mock.nodetool.InternalNodeProbe spies on StorageServiceMBean

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Test/dtest/java
• Bug Category: Code
• Severity: Low
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.0-alpha4

Source Control Link

https://github.com/apache/cassandra/commit/36a99bcdcc65eb2b3bb708f67e1bd75d35359f7f

Test and Documentation Plan

CI passes

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Andres de la Peña, Stefan Miklosovic

• Created: 12/Jan/23 13:54
• Updated: 12/Sep/23 13:02
• Resolved: 17/Jan/23 08:31

Description

While working on CASSANDRA-14361, when we included mockito-inline into the build to test the new functionality, unrelated tests in CI started to fail. (1)

This is happening because mockito, together with stuff which enables static mocking, just does not play together with our way of doing things in dtest framework.

The workaround is consisting of removing Mockito from InternalNodeProbe, it tries to spy on StorageService to not send any notifications back. This might be workarounded so we do not need Mockito hence tests are fixed and mocking of static methods is possible without any other tests failing.

(1) https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2168/#showFailuresLink

see also: https://github.com/mockito/mockito/issues/2203

Issue Links

• blocks: CASSANDRA-14361 Allow SimpleSeedProvider to resolve multiple IPs per DNS name