[CASSANDRA-18136] Upgrade maven-shade-plugin to fix shaded dtest JAR build

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Build, Packaging
• Bug Category: Packaging
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 5.0

Source Control Link

https://github.com/apache/cassandra/commit/fb95112427a8c64344563b6e499a6fb7bbf538d1

Test and Documentation Plan

This passes test if shaded dtest JARs build successfully and can be used by dependencies such as Harry.

• Assignee: Unassigned
• Reporter: Abe Ratnofsky

Authors

Abe Ratnofsky

Reviewers

Caleb Rackliffe

• Created: 05/Jan/23 19:29
• Updated: 12/Sep/23 13:02
• Resolved: 14/Mar/23 21:00

Description

Could not build shaded dtest JAR with ./build-shaded-dtest-jar.sh due to:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project cassandra-dtest-shaded: Error creating shaded jar: Problem shading JAR ~/Repos/apache/cassandra/target/cassandra-dtest-shaded-4.0.1-SNAPSHOT.jar entry net/openhft/chronicle/wire/YamlWire$TextValueIn.class: org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class net/openhft/chronicle/wire/YamlWire$TextValueIn.class: 65536 -> [Help 1] 

 

Tried on both Java 8 and Java 11, included ant clean / realclean / unlinking the entire ~/.m2/repository.

 

Fixed by upgrading maven-shade-plugin in relocate-dependencies.pom:

                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
-                <version>3.2.1</version>
+                <version>3.4.1</version>