[CASSANDRA-18113] fqltool dump results NPE when null value inserted using prepared query

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.8, 4.1.1, 5.0-alpha1, 5.0
• Component/s: Tool/fql
• Bug Category: Correctness
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/ba434b8231360347984c9a9906e5469767bfbcec

Test and Documentation Plan

added junit

• Assignee: n.v.harikrishna
• Reporter: n.v.harikrishna

Authors

n.v.harikrishna

Reviewers

Stefan Miklosovic

• Created: 13/Dec/22 18:54
• Updated: 12/Sep/23 13:02
• Resolved: 01/Feb/23 14:57

Description

Enable fullquerylog, prepare insert statement and bind it with a null value and execute it. Executing fqltool dump after insert will result into NullPointerException.
 
Stept to reproduce:
    * Create cluster using ccm
    * Create  a table something like:

    CREATE TABLE ks1.t2 (
        id int PRIMARY KEY,
        value text
    ) ;
 

    * Execute below code

    try (CqlSession cqlSession = CqlSession.builder().build()) {
        PreparedStatement preparedStatement = cqlSession.prepare("INSERT INTO ks1.t2 (id, value) VALUES (?, ?)");
        cqlSession.execute(preparedStatement.bind(6, null));
    }

    * Now running fqltool dump. It will run into NPE
 
 
Stack trace:

error: null
-- StackTrace --
java.lang.NullPointerException
    at net.openhft.chronicle.bytes.BytesStore.wrap(BytesStore.java:76)
    at net.openhft.chronicle.bytes.Bytes.wrapForRead(Bytes.java:179)
    at org.apache.cassandra.fqltool.commands.Dump.appendValuesToStringBuilder(Dump.java:222)
    at org.apache.cassandra.fqltool.commands.Dump.dumpQuery(Dump.java:179)
    at org.apache.cassandra.fqltool.commands.Dump.lambda$dump$0(Dump.java:123)
    at net.openhft.chronicle.queue.impl.single.StoreTailer.readDocument(StoreTailer.java:111)
    at org.apache.cassandra.fqltool.commands.Dump.dump(Dump.java:148)
    at org.apache.cassandra.fqltool.commands.Dump.run(Dump.java:68)
    at org.apache.cassandra.fqltool.FullQueryLogTool.main(FullQueryLogTool.java:65)