[CASSANDRA-18086] Bug fix for 'wait' time to be in nanoseconds for consistency instead of microseconds

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1.0
• Component/s: Feature/Lightweight Transactions
• Bug Category: Degradation - Performance Bug/Regression
• Severity: Normal
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.1

Source Control Link

https://github.com/apache/cassandra/pull/2038

Test and Documentation Plan

Add unit test to `ContentionStrategyTest.java` to check that the calculated wait is as expected.

• Assignee: Marianne Lyne Manaog
• Reporter: Marianne Lyne Manaog

Authors

Marianne Lyne Manaog

Reviewers

Ariel Weisberg, Benedict Elliott Smith, Blake Eggleston, Josh McKenzie

• Created: 02/Dec/22 12:37
• Updated: 17/Jan/23 10:21
• Resolved: 07/Dec/22 20:27

Description

While working on benchmarking Paxos improvements in OSS Cassandra, benedict was asked to review the work and thus found that the wait time was input in microseconds but then output incorrectly in the ContentionStrategy.java file, i.e., by summing up a wait time in nanoseconds with another wait time in microseconds (two different units used mistakenly). So, Benedict suggested the fix whereby the output wait time was then enforced to be consistently in nanoseconds.

Issue Links

• is caused by: CASSANDRA-17164 CEP-14: Paxos Improvements
• is related to: CASSANDRA-18097 Bug fix for formula for Clock.waitUntil
• supercedes: CASSANDRA-18097 Bug fix for formula for Clock.waitUntil