[CASSANDRA-18065] Flaky test org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0, 5.1
• Component/s: Tool/nodetool
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/c611632eb5ad3eafee00760b85d61e4626aab8d1

Test and Documentation Plan

run CI

• Assignee: Brandon Williams
• Reporter: Andres de la Peña

Authors

Brandon Williams

Reviewers

Berenguer Blasi

• Created: 22/Nov/22 13:08
• Updated: 12/Sep/23 13:02
• Resolved: 28/Aug/23 11:16

Description

The test org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling is fails intermittently on trunk with CircleCI:

• https://app.circleci.com/pipelines/github/adelapena/cassandra/2508/workflows/92f054d7-9386-498f-9ba4-330181cd4782/jobs/24692
• https://app.circleci.com/pipelines/github/adelapena/cassandra/2511/workflows/7aba8baa-0a6d-404a-b08b-c6a8078caca3/jobs/24706/tests

The failure looks like:

junit.framework.AssertionFailedError: Scheduled sampled tasks should be removed expected:<[]> but was:<[*.*]>
	at org.apache.cassandra.tools.TopPartitionsTest.testStartAndStopScheduledSampling(TopPartitionsTest.java:116)

I haven't seen this failure on Butler/Jenkins yet, but it can be reproduced with the CircleCI multiplexer:

.circleci/generate.sh -m \
  -e REPEATED_UTESTS_COUNT=2000 \
  -e REPEATED_UTESTS=org.apache.cassandra.tools.TopPartitionsTest

It seems to fail 11 times on 2000 runs.

Issue Links

• Discovered while testing: CASSANDRA-18060 Add aggregation scalar functions on collections