[CASSANDRA-17873] Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.8, 4.1-rc1, 4.1, 5.0-alpha1, 5.0
• Component/s: Build, Dependencies, Feature/UDF
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 4.0

Source Control Link

https://github.com/apache/cassandra/commit/ce1584ccc8ff65dc7e600f13f31b553732a1f12e

Test and Documentation Plan

Branch	CI run
4.0	CircleCI
4.1	CircleCI
trunk	CircleCI #1878 is the full CI run

No new tests added 

All known flaky tests:

4.0:

• testDropCompactStorage - CASSANDRA-17674

4.1:

• test_multiple_repair - CASSANDRA-17005, known timeouts. Probably will reopen that ticket or open a new one but not related to this work
• test_failed_bootstrap_wiped_node_can_join - CASSANDRA-17308

trunk: 

• nodeDownDuringMove - CASSANDRA-15239, also in this case I suspect some Circle issue, I am spinning things in a loop to add more info to that ticket but I don't think this failure has anything to do with this particular work
• test_failed_bootstrap_wiped_node_can_join - CASSANDRA-17308

 

EDIT: 

Latest pre-commit run:

4.0 #1983

• testMessageDeliveryOnReconnect - CASSANDRA-16677
• test_resume_stopped_build - Not related. For completeness this run shows it fails on current 4.0. I will open a new ticket 

4.1  #1984 all green

trunk is green (please ignore the repeated test, the rest is green) #1982

To https://github.com/apache/cassandra.git

   a9df34c62a..ce1584ccc8  cassandra-4.0 -> cassandra-4.0

   f90148a344..1df5dd671e  cassandra-4.1 -> cassandra-4.1

   ac68f24512..6f709ca0ec  trunk -> trunk

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Reviewers

Benedict Elliott Smith, Berenguer Blasi

• Created: 31/Aug/22 20:29
• Updated: 12/Sep/23 13:02
• Resolved: 20/Oct/22 18:22

Description

In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to provide Opcodes.ASM7 but only in 1 of 3 places. 

We need to update that for 4.0, 4.1 and trunk where we support JDK11.

Also, I think it will be good to add one place where we update that when we add new JDK support as now I see we will have to update it at 4 places at least already (also for the simulator where currently it is Opcodes.ASM7 there, correctly added). Also, we can add a note in build.xml for people updating ASM. I think many people practice updating Opcodes.ASM* with the update of ASM version but in our case with update of JDK, from what I see. We will need to switch to ASM9 when we add the JDK 17 support. One stop place for that and adding a note for maintainers sounds like the right way to move forward at least on trunk. 

But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I can tell.

Issue Links

• is caused by: CASSANDRA-15108 Support building Cassandra with JDK 11
• is related to: CASSANDRA-17971 Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
• Testing discovered: CASSANDRA-17975 SSTableIdGenerationTest.testRestartWithUUIDDisabled fails on trunk after CASSANDRA-17948
• Testing discovered: CASSANDRA-17980 Fix flaky Python DTest materialized_views_test.TestMaterializedViews.test_resume_stopped_build