Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-17873

Opcodes.ASM7 should be used in UDFByteCodeVerifier to support JDK11

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Correctness
    • Normal
    • Normal
    • User Report
    • All
    • None
    • 4.0
    • Hide
      Branch CI run
      4.0 CircleCI
      4.1 CircleCI
      trunk CircleCI #1878 is the full CI run

      No new tests added 

      All known flaky tests:

      4.0:

      4.1:

      • test_multiple_repair - CASSANDRA-17005, known timeouts. Probably will reopen that ticket or open a new one but not related to this work
      • test_failed_bootstrap_wiped_node_can_join - CASSANDRA-17308

      trunk: 

      • nodeDownDuringMove - CASSANDRA-15239, also in this case I suspect some Circle issue, I am spinning things in a loop to add more info to that ticket but I don't think this failure has anything to do with this particular work
      • test_failed_bootstrap_wiped_node_can_join - CASSANDRA-17308

       

      EDIT: 

      Latest pre-commit run:

      4.0 #1983

      4.1  #1984 all green

      trunk is green (please ignore the repeated test, the rest is green) #1982

      To https://github.com/apache/cassandra.git

         a9df34c62a..ce1584ccc8  cassandra-4.0 -> cassandra-4.0

         f90148a344..1df5dd671e  cassandra-4.1 -> cassandra-4.1

         ac68f24512..6f709ca0ec  trunk -> trunk

      Show
      Branch CI run 4.0 CircleCI 4.1 CircleCI trunk CircleCI  #1878 is the full CI run No new tests added  All known flaky tests: 4.0: testDropCompactStorage -  CASSANDRA-17674 4.1: test_multiple_repair - CASSANDRA-17005 , known timeouts. Probably will reopen that ticket or open a new one but not related to this work test_failed_bootstrap_wiped_node_can_join -  CASSANDRA-17308 trunk:  nodeDownDuringMove - CASSANDRA-15239 , also in this case I suspect some Circle issue, I am spinning things in a loop to add more info to that ticket but I don't think this failure has anything to do with this particular work test_failed_bootstrap_wiped_node_can_join -  CASSANDRA-17308   EDIT:   Latest pre-commit run: 4.0 #1983 testMessageDeliveryOnReconnect - CASSANDRA-16677 test_resume_stopped_build  - Not related. For completeness this run  shows it fails on current 4.0. I will open a new ticket  4.1   #1984  all green trunk is green (please ignore the repeated test, the rest is green) #1982 To https://github.com/apache/cassandra.git    a9df34c62a..ce1584ccc8  cassandra-4.0 -> cassandra-4.0    f90148a344..1df5dd671e  cassandra-4.1 -> cassandra-4.1    ac68f24512..6f709ca0ec  trunk -> trunk

    Description

      In CASSANDRA-15108 ASM was updated and UDFByteCodeVerifier was updated to provide Opcodes.ASM7 but only in 1 of 3 places. 

      We need to update that for 4.0, 4.1 and trunk where we support JDK11.

      Also, I think it will be good to add one place where we update that when we add new JDK support as now I see we will have to update it at 4 places at least already (also for the simulator where currently it is Opcodes.ASM7 there, correctly added). Also, we can add a note in build.xml for people updating ASM. I think many people practice updating Opcodes.ASM* with the update of ASM version but in our case with update of JDK, from what I see. We will need to switch to ASM9 when we add the JDK 17 support. One stop place for that and adding a note for maintainers sounds like the right way to move forward at least on trunk. 

      But for 4.0 and 4.1 we need at least to switch to ASM7 everywhere as far as I can tell.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            e.dimitrova Ekaterina Dimitrova Assign to me
            e.dimitrova Ekaterina Dimitrova
            Benedict Elliott Smith, Berenguer Blasi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment