[CASSANDRA-17867] Remove usage of deprecated javax certificate class

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Feature/Authorization
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=f77e6cd3a020f3ad777c6bd36973ca084a978f1f

Test and Documentation Plan

No testing changes; run full suite

• Assignee: Josh McKenzie Assign to me
• Reporter: Josh McKenzie

Authors

Josh McKenzie

Reviewers

Caleb Rackliffe

• Created: 26/Aug/22 16:05
• Updated: 12/Sep/23 13:02
• Resolved: 14/Sep/22 18:47

Description

When initially implemented, we used the older javax.security.cert.X509Certificate when initializing an IAuthenticator with certs - as nobody is yet using this interface, and there is a reasonable way to fix it to use the correct, non-deprecated cert classes, we should switch to the modern java.security.cert.Certificate class.

The broader reasoning here is that consumers of this interface would have to jump through serialization/deserialization hoops on each authentication check to use the newer X509Certificate implementation, which has data on which we depend for our mTLS implementation, and in this case we can just cast them to the appropriate class.

See https://docs.oracle.com/javase/9/docs/api/javax/security/cert/X509Certificate.html for further details