[CASSANDRA-17783] Move {{Schema.FORCE_LOAD_KEYSPACES}} and {{Schema.FORCE_LOAD_KEYSPACES_PROP}} to {{CassandraRelevantProps}}

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.1-rc1, 5.0-alpha1, 5.0
• Component/s: Local/Startup and Shutdown
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/a805e3267572a86dc731df509f0540fc85e08b78

Test and Documentation Plan

Tested in CQLSSTableWriterClientTest as it requires this prop to be set, which is done via the moved property in CQLSSTableWriter

 

See below for Trunk and 4.1 PRs for review and Circle CI runs.

 

 

• Assignee: Doug Rohrer
• Reporter: Doug Rohrer

Authors

Doug Rohrer

Reviewers

Brandon Williams, Jacek Lewandowski

• Created: 28/Jul/22 14:32
• Updated: 11/Dec/23 01:21
• Resolved: 08/Nov/22 07:47

Description

Schema.FORCE_LOAD_LOCAL_KEYSPACES_PROP and Schema.FORCE_LOAD_LOCAL_KEYSPACES should be moved to CassandraRelevantProps for two reasons.

1. Generally speaking, this is where these kinds of things live.
2. By having them in Schema, you can't actually use Schema.FORCE_LOAD_LOCAL_KEYSPACES_PROP without running all of the static initializers... and you want to use Schema.FORCE_LOAD_LOCAL_KEYSPACES_PROP to set the system property before the static initializer runs.

Issue Links

• relates to: CASSANDRA-17044 Refactor schema management to allow for schema source pluggability
• links to: GitHub Pull Request #1871