[CASSANDRA-17782] `DatabaseDescriptor#clientInitialization` should set the `newFailureDetector` (maybe to a NoOpFailureDetector?)

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-beta1, 4.1
• Component/s: Local/Startup and Shutdown
• Bug Category: Code - Bug - Unclear Impact
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.1-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/f5dc9a1c1e27ac5ea0cb972ceaf68d5993804d6f

Test and Documentation Plan

Tested by removing the call to setDefaultFailureDetector from CQLSSTableWriterClientTest.

• Assignee: Doug Rohrer
• Reporter: Doug Rohrer

Authors

Doug Rohrer

Reviewers

Brandon Williams, Caleb Rackliffe

• Created: 28/Jul/22 14:27
• Updated: 05/Oct/22 22:22
• Resolved: 10/Aug/22 19:16

Description

With the introduction of a configurable FailureDetector, client users of the cassandra-all jar now need to call not just `clientInitialization` but also `setDefaultFailureDetector` in order to avoid an NPE when the failure detector is constructed. This is a breaking change from previous versions where this was not necessary.

Calls to DatabaseDescriptor#clientInitialization should set newFailureDetector to something, either by calling setDefaultFailureDetector or creating a different (NoOp?) FailureDetector.

Issue Links

• is caused by: CASSANDRA-16930 Introduce Determinism (and other) Configuration Options