[CASSANDRA-17764] Extra writePreparedStatement call

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.6, 4.1-beta1, 4.1
• Component/s: Local/Caching
• Bug Category: Correctness
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0

Source Control Link

https://github.com/apache/cassandra/commit/a53bb7ab82e3d176e2594d2076dd8bf1f224b60e

Test and Documentation Plan

run CI

• Assignee: Brandon Williams
• Reporter: T Jake Luciani

Authors

Brandon Williams

Reviewers

Caleb Rackliffe

• Created: 21/Jul/22 16:06
• Updated: 05/Oct/22 22:22
• Resolved: 22/Jul/22 16:34

Description

There seems to be a double insert happening in QueryProcessor.storePreparedStatement()

 

https://github.com/apache/cassandra/blob/ab9ab903fa590409251e97fe075e02a64c8aa4f3/src/java/org/apache/cassandra/cql3/QueryProcessor.java#L788-L791

 

I think it's intended to only write to prepared statement  table when it's new to the cache vs every prepare call.  Regardless the extra one should be dropped.